Add back styling to lists within table cells (fixes #1141) #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This overrides the Datasette reset (see https://github.com/simonw/datasette/blob/d0fd833b8cdd97e1b91d0f97a69b494895d82bee/datasette/static/app.css#L35-L38), to add back the default styling of list items displayed within Datasette table cells.
bobwhitelock
commented
Mar 9, 2021
| @@ -452,6 +452,10 @@ table a:link { | |||
| margin-left: -10%; | |||
| font-size: 0.8em; | |||
| } | |||
| .rows-and-columns td ol,ul { | |||
| list-style: initial; | |||
| list-style-position: inside; | |||
There was a problem hiding this comment.
This is needed otherwise the bullet point marker appears in the neighbouring cell to the left, rather than the cell with the bullet point content.
Codecov Report
@@ Coverage Diff @@
## main #1252 +/- ##
==========================================
- Coverage 91.56% 91.51% -0.05%
==========================================
Files 34 34
Lines 4244 4244
==========================================
- Hits 3886 3884 -2
- Misses 358 360 +2
Continue to review full report at Codecov.
|
|
Neat fix, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overrides the Datasette reset - see
datasette/datasette/static/app.css
Lines 35 to 38 in d0fd833
Following this change, the same content as in the original issue looks like this: