Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request object utility for handling POST form data #700

Closed
simonw opened this issue Mar 17, 2020 · 1 comment
Closed

Request object utility for handling POST form data #700

simonw opened this issue Mar 17, 2020 · 1 comment
Labels
small

Comments

@simonw
Copy link
Owner

simonw commented Mar 17, 2020 •
edited
Loading

This is also going to need me to handle POST form submissions which means I need to be able to parse the form body. I guess that will go in datasette/utils/asgi.py.

Originally posted by @simonw in #698 (comment)
@simonw simonw added the small label Mar 17, 2020
@simonw
Copy link
Owner Author

simonw commented Mar 17, 2020

Right now the Request class is created by passing it an ASGI scope:

datasette/datasette/utils/asgi.py

Line 174 in dc80e77

request = Request(scope)

I can extend this to Request(scope, receive) - then I can add a await request.post_vars() method.

@simonw simonw closed this as completed in a000c80 Mar 17, 2020
simonw added a commit that referenced this issue Mar 26, 2020
@simonw
await Request(scope, receive).post_vars() method, closes #700
058fc3e 
Needed for #698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw