Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract codemirror SQL editor out into a plugin #530

Closed
simonw opened this issue Jun 25, 2019 · 1 comment
Closed

Extract codemirror SQL editor out into a plugin #530

simonw opened this issue Jun 25, 2019 · 1 comment

Comments

@simonw
Copy link
Owner

simonw commented Jun 25, 2019

Right now codemirror (used for the SQL editor on https://latest.datasette.io/fixtures?sql=select+*+from+%5B123_starts_with_digits%5D ) is the only JavaScript in Datasette.

It's also the only vendored dependency.

I'd like to move it out to a plugin. But... ideally I would like that plugin to be part of the default "pip install datasette" experience.

I don't know what the best pattern for optional dependencies is. I don't want to have to tell people to run pip install datasette[full]

@simonw simonw changed the title Extract codemirror SQL editor our into a plugin Extract codemirror SQL editor out into a plugin Jun 25, 2019
@simonw
Copy link
Owner Author

simonw commented Oct 1, 2020

I've changed my mind - especially since Datasette now ships with default JavaScript for the column menus in #981. I'm not going to extract CodeMirror into a plugin, I'll leave it where it is.

@simonw simonw closed this as completed Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant