Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility: add a lang attribute to html #2348

Closed
CharlesNepote opened this issue May 16, 2024 · 1 comment
Closed

Accessibility: add a lang attribute to html #2348

CharlesNepote opened this issue May 16, 2024 · 1 comment
Labels
accessibility enhancement

Comments

@CharlesNepote
Copy link

CharlesNepote commented May 16, 2024 •
edited
Loading

When analyzing datasette accessibility, one of the main (and easy to fix?) issue is the lack of lang attribute into thehtml tag: see https://qualweb.di.fc.ul.pt/evaluator/https%253A%252F%252Fglobal-power-plants.datasettes.com%252Fglobal-power-plants%252Fglobal-power-plants

The norm: https://www.w3.org/WAI/standards-guidelines/act/rules/b5c3f8/

Do we only have to fix: https://github.com/simonw/datasette/blob/main/datasette/templates/base.html ?

Is it ok to hard code this since datasette is only in English for the moment: <html lang="en">?
@simonw
Copy link
Owner

simonw commented Jun 11, 2024

Yeah, I think adding lang="en" is fine for the moment. When Datasette gets UI translations into other languages we can revisit.

@simonw simonw closed this as completed in 7437d40 Jun 11, 2024
@simonw simonw mentioned this issue Aug 5, 2024
Closed
simonw added a commit that referenced this issue Aug 5, 2024
@simonw
Release notes for 1.0a14, refs #2381
5bd6853 
Refs #2306, #2307, #2311, #2319, #2341, #2348, #2352, #2353, #2358, #2359, #2360, #2375
simonw added a commit that referenced this issue Aug 5, 2024
@simonw
Release 1.0a14
f6bd2bf 
Refs #2306, #2307, #2311, #2319, #2341, #2348, #2352, #2353, #2358, #2359, #2360, #2375

Closes #2381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonw @CharlesNepote