Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat allow blocks in metadata as if they were in config #2249

Closed
simonw opened this issue Feb 1, 2024 · 1 comment
Closed

Treat allow blocks in metadata as if they were in config #2249

simonw opened this issue Feb 1, 2024 · 1 comment
Labels
design security
Milestone
Datasette 1.0a8

Comments

@simonw
Copy link
Owner

simonw commented Feb 1, 2024

I just realized 35deaab moved allow blocks from metadata to config.

Could this result in previously secured instances opening up when the upgrade is applied? If so, it would be better to fail hard (like we used to with plugin configuration prior to #2248).
@simonw simonw added this to the Datasette 1.0a8 milestone Feb 1, 2024
@simonw simonw mentioned this issue Feb 1, 2024
Closed
@simonw
Copy link
Owner Author

simonw commented Feb 5, 2024

It should treat them as if they were in config. I've decided to support that for everything - metadata gets silently upgraded to config, rather than breaking things for people.

@simonw simonw changed the title Should Datasette fail if allow blocks are in metadata? Treat allow blocks in metadata as if they were in config Feb 5, 2024
This was referenced Feb 5, 2024
Merged
Closed
@simonw simonw closed this as completed in 9ac9f01 Feb 7, 2024
simonw added a commit that referenced this issue Feb 7, 2024
@simonw
Changelog for #2249
e8cc247
simonw added a commit that referenced this issue Feb 7, 2024
@simonw
1.0a8 release notes
ad01f9d 
Closes #2243

* Changelog for jinja2_environment_from_request and plugin_hook_slots
* track_event() in changelog
* Remove Using YAML for metadata section - no longer necessary now we show YAML and JSON examples everywhere.
* Configuration via the command-line section - #2252
* JavaScript plugins in release notes, refs #2052
* /-/config in changelog, refs #2254

Refs #2052, #2156, #2243, #2247, #2249, #2252, #2254
simonw added a commit that referenced this issue Feb 7, 2024
@simonw
Release 1.0a8
9989f25 
Refs Refs #2052, #2156, #2243, #2247, #2249, #2252, #2254, #2258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design security
Projects
None yet
Milestone
Datasette 1.0a8
Development

No branches or pull requests
1 participant
@simonw