Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

click-default-group-wheel dependency conflict #2197

Closed
ar-jan opened this issue Oct 6, 2023 · 3 comments
Closed

click-default-group-wheel dependency conflict #2197

ar-jan opened this issue Oct 6, 2023 · 3 comments

Comments

@ar-jan
Copy link

ar-jan commented Oct 6, 2023

I upgraded my dependencies, then ran into this problem running datasette inspect:

env/lib/python3.9/site-packages/datasette/cli.py", line 6, in
from click_default_group import DefaultGroup
ModuleNotFoundError: No module named 'click_default_group'

Turns out the released version of datasette still depends on click-default-group-wheel, so click-default-group doesn't get installed/recognized:

$ virtualenv venv
$ source venv/bin/activate
$ pip install datasette
$ pip list | grep click-default-group
click-default-group       1.2.4
click-default-group-wheel 1.2.3
$ python -c "from click_default_group import DefaultGroup"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'click_default_group'
$ pip install --force-reinstall click-default-group
...
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed.
This behaviour is the source of the following dependency conflicts.
datasette 0.64.4 requires click-default-group-wheel>=1.2.2, which is not installed.
Successfully installed click-8.1.7 click-default-group-1.2.4
@simonw
Copy link
Owner

simonw commented Oct 8, 2023

Replicated this myself:

cd /tmp
mkdir dddd
cd dddd
pipenv shell
pip install datasette
pip freeze | grep click
click==8.1.7
click-default-group==1.2.4
click-default-group-wheel==1.2.3

Yeah this is bad, I'll ship a 0.64.5 release.

simonw added a commit that referenced this issue Oct 8, 2023
simonw added a commit that referenced this issue Oct 8, 2023
@simonw
Copy link
Owner

simonw commented Oct 8, 2023

Confirmed - I ran this in a fresh virtual environment:

pip install --no-cache datasette

And now:

pip freeze | grep click
click==8.1.7
click-default-group==1.2.4
datasette --version
datasette, version 0.64.5

@simonw
Copy link
Owner

simonw commented Oct 8, 2023

https://lite.datasette.io/?install=datasette-packages#/-/packages confirms that Datasette Lite still works (click-default-group-wheel was originally built to allow it to run) and that it's now using these packages:

    "click-default-group": "1.2.4",
    "datasette": "0.64.5",

Full list:

{
    "aiofiles": "23.2.1",
    "anyio": "3.7.1",
    "asgi-csrf": "0.9",
    "asgiref": "3.7.2",
    "certifi": "2022.12.7",
    "click": "8.1.3",
    "click-default-group": "1.2.4",
    "datasette": "0.64.5",
    "datasette-packages": "0.2",
    "h11": "0.12.0",
    "httpcore": "0.15.0",
    "httpx": "0.23.0",
    "hupper": "1.12",
    "idna": "3.4",
    "itsdangerous": "2.1.2",
    "janus": "1.0.0",
    "Jinja2": "3.1.2",
    "MarkupSafe": "2.1.2",
    "mergedeep": "1.3.4",
    "micropip": "0.3.0",
    "packaging": "23.0",
    "Pint": "0.22",
    "pip": "23.2.1",
    "pluggy": "1.0.0",
    "pyparsing": "3.0.9",
    "python-multipart": "0.0.6",
    "PyYAML": "6.0",
    "rfc3986": "1.5.0",
    "setuptools": "67.6.1",
    "sniffio": "1.3.0",
    "typing-extensions": "4.5.0",
    "uvicorn": "0.23.2"
}

@simonw simonw closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants