Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge database index page and query view #2110

Closed
simonw opened this issue Jul 26, 2023 · 1 comment
Closed

Merge database index page and query view #2110

simonw opened this issue Jul 26, 2023 · 1 comment
Labels
refactor
Milestone
Datasette 1.0a3

Comments

@simonw
Copy link
Owner

simonw commented Jul 26, 2023

Refs:

The idea here is that hitting /content without a ?sql= will show an empty result set AND default to including a bunch of extras about the list of tables in the database.

Then I won't have to think about /content and /content?sql= as separate pages any more.
@simonw
Copy link
Owner Author

simonw commented Jul 26, 2023

Changed my mind on this - I'm going to have the query_view mapped to /db but have the first code on there notice if ?sql= is missing and return a database_view() function instead.

simonw added a commit that referenced this issue Jul 26, 2023
@simonw
New database_view() works for HTML and JSON
2e40a50 
But it breaks when it dispatches ?sql= to the new query_view function.

Refs #2111, closes #2110
@simonw simonw closed this as completed Jul 26, 2023
simonw added a commit that referenced this issue Aug 8, 2023
@simonw
New JSON design for query views (#2118)
1377a29 
* Refs #2111, closes #2110
* New Context dataclass/subclass mechanism, refs #2127
* Define QueryContext and extract get_tables() method, refs #2127
* Fix OPTIONS bug by porting DaatbaseView to be a View subclass
* Expose async_view_for_class.view_class for test_routes test
* Error/truncated aruments for renderers, closes #2130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
Datasette 1.0a3
Development

No branches or pull requests
1 participant
@simonw