Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell test failure #2089

Closed
simonw opened this issue Jun 29, 2023 · 5 comments
Closed

codespell test failure #2089

simonw opened this issue Jun 29, 2023 · 5 comments

Comments

@simonw
Copy link
Owner

simonw commented Jun 29, 2023

https://github.com/simonw/datasette/actions/runs/5413443676/jobs/9838999356

  codespell docs/*.rst --ignore-words docs/codespell-ignore-words.txt
  codespell datasette -S datasette/static --ignore-words docs/codespell-ignore-words.txt
  shell: /usr/bin/bash -e {0}
  env:
    pythonLocation: /opt/hostedtoolcache/Python/3.9.17/x64
    LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.17/x64/lib
docs/metadata.rst:192: displaing ==> displaying

This failure is legit, it found a spelling mistake:

Datasette defaults to displaing 100 rows per page, for both tables and views. You can change this default page size on a per-table or per-view basis using the ``"size"`` key in ``metadata.json``:

@simonw
Copy link
Owner Author

simonw commented Jun 29, 2023

I'm not sure why I can't duplicate this failure in my local development environment:

% codespell docs/metadata.rst

It finds no errors.

@simonw
Copy link
Owner Author

simonw commented Jun 29, 2023

Looks like in CI it's running 2.2.5:

Collecting codespell (from datasette==1.0a2)
  Downloading codespell-2.2.5-py3-none-any.whl (242 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 242.7/242.7 kB 31.1 MB/s eta 0:00:00

But on my laptop it's 2.2.2:

% codespell --version
2.2.2

@simonw
Copy link
Owner Author

simonw commented Jun 29, 2023

Yes, upgrading locally got me the correct version and the test failure:

% pip install -U codespell
Requirement already satisfied: codespell in /Users/simon/.local/share/virtualenvs/datasette-AWNrQs95/lib/python3.10/site-packages (2.2.2)
Collecting codespell
  Downloading codespell-2.2.5-py3-none-any.whl (242 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 242.7/242.7 kB 4.9 MB/s eta 0:00:00
Installing collected packages: codespell
  Attempting uninstall: codespell
    Found existing installation: codespell 2.2.2
    Uninstalling codespell-2.2.2:
      Successfully uninstalled codespell-2.2.2
Successfully installed codespell-2.2.5
% codespell docs/metadata.rst
docs/metadata.rst:192: displaing ==> displaying

simonw added a commit that referenced this issue Jun 29, 2023
simonw added a commit that referenced this issue Jun 29, 2023
Also ensure codespell runs as part of just lint
@simonw
Copy link
Owner Author

simonw commented Jun 29, 2023

Confirmed, this was a 2.2.5 change: https://github.com/codespell-project/codespell/releases/tag/v2.2.5

@simonw
Copy link
Owner Author

simonw commented Jun 29, 2023

Spell check is passing now.

@simonw simonw closed this as completed Jun 29, 2023
simonw added a commit that referenced this issue Jul 26, 2023
simonw added a commit that referenced this issue Jul 26, 2023
Also ensure codespell runs as part of just lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant