-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
max_signed_tokens_ttl
setting for a maximum duration on API tokens
#1858
Comments
I'm going for consistency with So |
max_signed_tokens_ttl
setting for a maximum duration on API tokens
I just realized this can't easily affect the More to the point: even if it did, someone could abuse their knowledge of the secret to create a signed non-expiring token even on servers that didn't want to support those. So I actually need to redesign the token format: it needs to store the timestamp when the token was created and the intended duration, NOT the timestamp that the token expires at. Otherwise it's not possible for servers to enforce |
New token design: {
"a": "actor-id",
"t": "creation timestamp as integer",
"d": "intended duration in seconds, or blank if no duration set"
} This is in place of the |
Also redesigned token format to include creation time and optional duration.
It's currently possible to use
/-/create-token
to create a token that lasts forever.Some administrators may wish to have a maximum expiry instead. I should support that with a setting.
The text was updated successfully, but these errors were encountered: