Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing against Python 3.6 #1606

Closed
simonw opened this issue Jan 20, 2022 · 3 comments
Closed

Tests failing against Python 3.6 #1606

simonw opened this issue Jan 20, 2022 · 3 comments
Labels
bug ci dependencies Pull requests that update a dependency file

Comments

@simonw
Copy link
Owner

simonw commented Jan 20, 2022

https://github.com/simonw/datasette/runs/4877484366

E           File "/opt/hostedtoolcache/Python/3.6.15/x64/lib/python3.6/site-packages/uvicorn/server.py", line 67, in run
E             return asyncio.run(self.serve(sockets=sockets))
E         AttributeError: module 'asyncio' has no attribute 'run'

I think this may mean uvicorn has dropped support for Python 3.6.

@simonw simonw added bug ci dependencies Pull requests that update a dependency file labels Jan 20, 2022
@simonw
Copy link
Owner Author

simonw commented Jan 20, 2022

simonw/latest-datasette-with-all-plugins@1e12ffe shows that 5 days ago Datasette upgraded from Uvicorn 0.16 to 0.17

Sure enough, in the changelog for 0.17: https://github.com/encode/uvicorn/blob/0.17.0/CHANGELOG.md

  • Drop Python 3.6 support (#1261) 06/01/22

@simonw
Copy link
Owner Author

simonw commented Jan 20, 2022

https://pypistats.org/packages/datasette shows Python 3.6 is 0.24% of Datasette downloads.

image

@simonw
Copy link
Owner Author

simonw commented Jan 20, 2022

Relevant:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant