explain query plan select is too strict about whitespace

[simonw]

explain query plan select * from facetable is allowed: https://latest.datasette.io/fixtures?sql=explain+query+plan+select+*+from+facetable

But... explain query plan select * from facetable (with two spaces before the select) returns a "Statement must be a SELECT" error: https://latest.datasette.io/fixtures?sql=explain+query+plan++select+*+from+facetable

[simonw]

Relevant code:

datasette/datasette/utils/__init__.py

Lines 163 to 170 in 8584993

	allowed_sql_res = [
	re.compile(r"^select\b"),
	re.compile(r"^explain select\b"),
	re.compile(r"^explain query plan select\b"),
	re.compile(r"^with\b"),
	re.compile(r"^explain with\b"),
	re.compile(r"^explain query plan with\b"),
	]

datasette/datasette/utils/__init__.py

Lines 195 to 204 in 8584993

	def validate_sql_select(sql):
	sql = "\n".join(
	line for line in sql.split("\n") if not line.strip().startswith("--")
	)
	sql = sql.strip().lower()
	if not any(r.match(sql) for r in allowed_sql_res):
	raise InvalidSql("Statement must be a SELECT")
	for r, msg in disallawed_sql_res:
	if r.search(sql):
	raise InvalidSql(msg)

[simonw]

I think this is the fix:

re.compile(r"^explain\s+query\s+plan\s+select\b"),

[simonw]

This works now: https://latest.datasette.io/fixtures?sql=explain+query+plan++select+*+from+facetable