Custom pages don't work on windows

[ryascott]

It seems that custom pages don't work when put in templates/pages

To reproduce on datasette version 0.59.4 using PowerShell on WIndows 10 with Python 3.10.0

mkdir -p templates/pages

echo "hello world" >> templates/pages/about.html

Start datasette

datasette --template-dir templates/

Navigate to http://127.0.0.1:8001/about and receive:

Error 404:
Database not found: about

[simonw]

Here's the relevant code:

datasette/datasette/app.py

Lines 1204 to 1219 in 4094741

	else:
	# Is there a pages/* template matching this path?
	route_path = request.scope.get("route_path", request.scope["path"])
	template_path = os.path.join("pages", *route_path.split("/")) + ".html"
	try:
	template = self.ds.jinja_env.select_template([template_path])
	except TemplateNotFound:
	template = None
	if template is None:
	# Try for a pages/blah/{name}.html template match
	for regex, wildcard_template in self.page_routes:
	match = regex.match(route_path)
	if match is not None:
	context.update(match.groupdict())
	template = wildcard_template
	break

It's using route_path.split("/") which should be OK because that's the incoming request.path path - which I would expect to use / even on Windows. Then it uses os.path.join which should do the right thing.

I need to get myself a proper Windows development environment setup to investigate this one.

[simonw]

I understand the problem now! pallets/jinja#1378 (comment)

Jinja template names/paths are not always filesystem paths. So regardless of the OS Jinja always uses forward slashes.

[simonw]

Filed an issue with Jinja suggesting a documentation update:

• Document that get_template() template names should use / even on Windows pallets/jinja#1578