Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects')

[simonw]

This is caused by a change made to httpx in https://github.com/encode/httpx/releases/tag/0.20.0

[simonw]

Upgrading to 0.20.0 gives me lots of the following errors:

'{"ok": false, "error": "Database not found: .json?_sort=relationships", "status": 404, "title": null}'

It looks like the full query string is now being treated as the name of the database.

[simonw]

I think the issue is in route_path():

> /Users/simon/Dropbox/Development/datasette/datasette/app.py(1182)route_path()
-> response = await view(request, send)
(Pdb) path
'/_memory.json?sql=select+sqlite_version()'

[simonw]

(Pdb) request.scope['path']
'/_memory.json'
(Pdb) request.scope['raw_path']
b'/_memory.json?sql=select+sqlite_version()'

So raw_path now includes the query string.

[simonw]

This is weird - as far as I can tell httpx has included the query string in raw_path for well over a year: encode/httpx@8e4a8a1#diff-c9a78eb3b5f5c4fac4e5552165fbdd5320c7e3fadf9eedabcb5461393466c090R235

[simonw]

I think this is the change in httpx which is causing the bug for me: encode/httpx@ff9813e#diff-0d0cbe9ebcd03cc8c780b0407762540a082f70cc64257f2fcd588cc30f43c15cR96

Previously it was using path from path, _, query = full_path.partition(b"?") to populate the raw_path key - but it changed to instead using request.url.raw_path which presumably implements the logic that includes the query string.