Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Jinja2 version 3.0 #1331

Closed
MarkusH opened this issue May 17, 2021 · 10 comments
Closed

Add support for Jinja2 version 3.0 #1331

MarkusH opened this issue May 17, 2021 · 10 comments

Comments

@MarkusH
Copy link

MarkusH commented May 17, 2021

A week ago, The Pallets Project released new major versions of several of its projects. Among those updates is one for Jinja2, which bumps it to version 3.0.0.

I'd like for datasette to support Jinaj2 version 3.0.

@simonw
Copy link
Owner

simonw commented May 17, 2021

Datasette uses async templates which evidently have been improved in Jinja 2 3.0.

@simonw
Copy link
Owner

simonw commented May 17, 2021

The tests are passing on #1324 so this may not require any code changes at all!

@MarkusH
Copy link
Author

MarkusH commented May 17, 2021

Wow, you are fast!

I didn't notice dependabot had opened a PR already. I was about to.

@simonw
Copy link
Owner

simonw commented May 17, 2021

I wonder if there are any new 3.0 features we should be taking advantage of here that would justify pinning to 3.0 minimum?

@MarkusH
Copy link
Author

MarkusH commented May 17, 2021

I wonder if there are any new 3.0 features we should be taking advantage of here that would justify pinning to 3.0 minimum?

The changelog reads like bug fixes and removal of deprecated parts to me

@MarkusH
Copy link
Author

MarkusH commented May 20, 2021

Any chance you could push a new datasette release with the updated dependencies in the setup.py, @simonw?

@stonebig
Copy link

I'm stuck also because datasette wants itsdangerous~=1.1 instead of allowing itsdangerous-2.0.0

@simonw
Copy link
Owner

simonw commented May 23, 2021

I'm going to push an alpha release with the new dependencies shortly.

@simonw
Copy link
Owner

simonw commented May 23, 2021

I'm stuck also because datasette wants itsdangerous~=1.1 instead of allowing itsdangerous-2.0.0

Bumped that dependency in b64d872

@simonw
Copy link
Owner

simonw commented May 23, 2021

Here's an alpha release with updated dependencies: https://pypi.org/project/datasette/0.57a0/

@simonw simonw closed this as completed May 23, 2021
simonw added a commit that referenced this issue May 24, 2021
simonw added a commit that referenced this issue May 24, 2021
simonw added a commit that referenced this issue May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants