Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Datasette tags missing from Docker Hub #1281

Closed
simonw opened this issue Mar 29, 2021 · 7 comments
Closed

Latest Datasette tags missing from Docker Hub #1281

simonw opened this issue Mar 29, 2021 · 7 comments
Labels

Comments

@simonw
Copy link
Owner

simonw commented Mar 29, 2021

Spotted this while testing #1249 (comment)_

https://hub.docker.com/r/datasetteproject/datasette/tags?page=1&ordering=last_updated isn't showing the tags for any version more recent than 0.54.1 - we are up to 0.56 now.

But the :latest tag is for the new 0.56 release.

@simonw
Copy link
Owner Author

simonw commented Mar 29, 2021

Here's the diff between Dockerfile in 0.54.1 and 0.56: 0.54.1...0.56#diff-551d1fcf87f78cc3bc18a7b332a4dc5d8773a512062df881c5aba28a6f5c48d7

Banners_and_Alerts_and_Comparing_0_54_1___0_56_·_simonw_datasette

@simonw
Copy link
Owner Author

simonw commented Mar 29, 2021

https://github.com/simonw/datasette/runs/1763835467?check_suite_focus=true for Datasette 0.54 worked, and the output included this:

Successfully tagged ***/datasette:0.54
The push refers to repository [docker.io/***/datasette]
aedd33c6b161: Preparing
...
aedd33c6b161: Pushed
0.54: digest: sha256:65c7e579d1c29755dac5c1ca86b1e97fa88c48bd3d724ac3e02988d0da296140 size: 2005
aedd33c6b161: Preparing
...
5dacd731af1b: Layer already exists
latest: digest: sha256:65c7e579d1c29755dac5c1ca86b1e97fa88c48bd3d724ac3e02988d0da296140 size: 2005

Here's that same section of output from the 0.56 release:

Successfully tagged ***/datasette:0.56
Using default tag: latest
The push refers to repository [docker.io/***/datasette]
4d4a9976adcc: Preparing
...
9b2132a0d5cf: Pushed
latest: digest: sha256:2250d0fbe57b1d615a8d6df0c9d43deb9533532e00bac68854773d8ff8dcf00a size: 1793

The difference here is the "Using default tag: latest" bit.

@simonw
Copy link
Owner Author

simonw commented Mar 29, 2021

https://docs.docker.com/engine/reference/commandline/push/#push-all-tags-of-an-image

Use the -a (or --all-tags) option to push all tags of a local image.

simonw added a commit that referenced this issue Mar 29, 2021
@simonw
Copy link
Owner Author

simonw commented Mar 29, 2021

I'm going to attempt to fix this manually for the 0.56 release, by building and tagging it by hand and then pushing the 0.56 tag to Docker Hub.

@simonw
Copy link
Owner Author

simonw commented Mar 29, 2021

I'm going to build a new GitHub Actions workflow for this that lets me manually specify a tag to build and push as a Docker image.

@simonw
Copy link
Owner Author

simonw commented Mar 29, 2021

Got this error:

"docker tag" requires exactly 2 arguments.
See 'docker tag --help'.

Usage:  docker tag SOURCE_IMAGE[:TAG] TARGET_IMAGE[:TAG]

Create a tag TARGET_IMAGE that refers to SOURCE_IMAGE

@simonw simonw closed this as completed Mar 29, 2021
simonw added a commit that referenced this issue Mar 29, 2021
simonw added a commit that referenced this issue May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant