Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default menu links should check a real permission #1068

Closed
simonw opened this issue Oct 30, 2020 · 5 comments
Closed

Default menu links should check a real permission #1068

simonw opened this issue Oct 30, 2020 · 5 comments

Comments

@simonw
Copy link
Owner

simonw commented Oct 30, 2020

@hookimpl
def menu_links(datasette, actor):
if actor and actor.get("id") == "root":

This should check a named permission so that it can be customized by permission plugins.

@simonw simonw added this to the 0.51 milestone Oct 30, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 30, 2020

@simonw
Copy link
Owner Author

simonw commented Oct 30, 2020

Permission idea: debug-menu

@simonw
Copy link
Owner Author

simonw commented Oct 30, 2020

@simonw
Copy link
Owner Author

simonw commented Oct 30, 2020

I mainly want this so I can add that debug menu to my Dogsheep.

@simonw simonw closed this as completed in 222f79b Oct 30, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 30, 2020

simonw added a commit that referenced this issue Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant