Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table actions menu plus plugin hook #1066

Closed
simonw opened this issue Oct 30, 2020 · 3 comments
Closed

Table actions menu plus plugin hook #1066

simonw opened this issue Oct 30, 2020 · 3 comments
Labels
plugins
Milestone
0.51

Comments

@simonw
Copy link
Owner

simonw commented Oct 30, 2020

For the table actions: attaching it to a cog icon next to the table name could make sense.

data__faa-wildlife-strikes__26_rows_where_where_AIRPORT____OIL_RIG__sorted_by_rowid_and_Fix_table_name_in_spatialite_example_command_by_jsfenfen_·_Pull_Request__1022_·_simonw_datasette

This is the column action icon at twice the size, color #666.
Originally posted by @simonw in #690 (comment)
@simonw simonw added the plugins label Oct 30, 2020
@simonw simonw added this to the 0.51 milestone Oct 30, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 30, 2020

This will use a very similar implementation to the navigation menu in #1064 - similar plugin hook and I'll use a <details><summary> to implement it.

@simonw simonw closed this as completed in 2f7731e Oct 30, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 30, 2020

The cog only appears if at least one table action has been registered by a plugin. It looks like this:

table-actions

@simonw
Copy link
Owner Author

simonw commented Oct 30, 2020

Documentation: https://docs.datasette.io/en/latest/plugin_hooks.html#table-actions-datasette-actor-database-table

simonw added a commit that referenced this issue Oct 30, 2020
@simonw
Release 0.51a1
0e1e89c 
Refs #1056, #1039, #998, #1045, #1033, #1036, #1034, #976, #1057, #1058, #1053, #1064, #1066
@simonw simonw mentioned this issue Oct 30, 2020
Closed
simonw added a commit that referenced this issue Oct 30, 2020
@simonw
cursor: pointer; on the new menu icons
9f0987c 
Refs #1064, #1066
@simonw simonw mentioned this issue Oct 30, 2020
Closed
simonw referenced this issue Oct 31, 2020
@simonw
Release 0.51
d53d747 
Refs #1014, #1016, #1019, #1023, #1027, #1028, #1033, #1034, #1036, #1039

Closes #1076
simonw added a commit that referenced this issue Nov 2, 2020
@simonw
Add database/table actions to pattern portfolio
d6257e3 
Refs #1066, #1077
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugins
Projects
None yet
Milestone
0.51
Development

No branches or pull requests
1 participant
@simonw