Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.csv should link to .blob downloads #1063

Closed
1 task done
simonw opened this issue Oct 29, 2020 · 3 comments
Closed
1 task done

.csv should link to .blob downloads #1063

simonw opened this issue Oct 29, 2020 · 3 comments
Milestone

Comments

@simonw
Copy link
Owner

simonw commented Oct 29, 2020

  • Update .csv output to link to these things (and get that xfail test to pass)
  • Add a .csv?_blob_base64=1 argument that causes them to be output in base64 in the CSV

Moving the CSV work to a separate ticket.
Originally posted by @simonw in #1061 (comment)

@simonw simonw added this to the 0.51 milestone Oct 29, 2020
@simonw simonw added the small label Oct 29, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 29, 2020

Remove this xfail and import pytest:

@pytest.mark.xfail
def test_table_csv_blob_columns(app_client):
response = app_client.get("/fixtures/binary_data.csv")
assert response.status == 200
assert "text/plain; charset=utf-8" == response.headers["content-type"]
assert EXPECTED_TABLE_CSV == textwrap.dedent(
"""
rowid,data
1,/fixtures/binary_data/-/blob/1/data.blob
2,/fixtures/binary_data/-/blob/1/data.blob
""".strip().replace(
"\n", "\r\n"
)
)

@simonw
Copy link
Owner Author

simonw commented Oct 29, 2020

This will close #1034.

@simonw
Copy link
Owner Author

simonw commented Oct 29, 2020

I'm not going to do the base64 thing unless someone asks for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant