--cors for /name.db downloads, refs #1057

datasette/utils/asgi.py

@@ -247,9 +247,9 @@ async def asgi_start(send, status, headers=None, content_type="text/plain"):
 
 
 async def asgi_send_file(
-    send, filepath, filename=None, content_type=None, chunk_size=4096
+    send, filepath, filename=None, content_type=None, chunk_size=4096, headers=None
 ):
-    headers = {}
+    headers = headers or {}
     if filename:
         headers["content-disposition"] = 'attachment; filename="{}"'.format(filename)
     first = True
@@ -395,13 +395,22 @@ def redirect(cls, path, status=302, headers=None):
 
 class AsgiFileDownload:
     def __init__(
-        self, filepath, filename=None, content_type="application/octet-stream"
+        self,
+        filepath,
+        filename=None,
+        content_type="application/octet-stream",
+        headers=None,
     ):
+        self.headers = headers or {}
         self.filepath = filepath
         self.filename = filename
         self.content_type = content_type
 
     async def asgi_send(self, send):
         return await asgi_send_file(
-            send, self.filepath, filename=self.filename, content_type=self.content_type
+            send,
+            self.filepath,
+            filename=self.filename,
+            content_type=self.content_type,
+            headers=self.headers,
         )

datasette/views/database.py

@@ -144,10 +144,14 @@ async def view_get(self, request, database, hash, correct_hash_present, **kwargs
         if not db.path:
             raise DatasetteError("Cannot download database", status=404)
         filepath = db.path
+        headers = {}
+        if self.ds.cors:
+            headers["Access-Control-Allow-Origin"] = "*"
         return AsgiFileDownload(
             filepath,
             filename=os.path.basename(filepath),
             content_type="application/octet-stream",
+            headers=headers,
         )
 
 

tests/fixtures.py

@@ -227,7 +227,7 @@ def app_client_with_dot():
 
 @pytest.fixture(scope="session")
 def app_client_with_cors():
-    with make_app_client(cors=True) as client:
+    with make_app_client(is_immutable=True, cors=True) as client:
         yield client
 
 

tests/test_api.py

@@ -1739,6 +1739,7 @@ def test_trace(app_client):
 @pytest.mark.parametrize(
     "path,status_code",
     [
+        ("/fixtures.db", 200),
         ("/fixtures.json", 200),
         ("/fixtures/no_primary_key.json", 200),
         # A 400 invalid SQL query should still have the header: