Support OPTIONS without 500, closes #1001

simonw · Oct 9, 2020 · 7249ac5 · 7249ac5
1 parent 703439b
commit 7249ac5
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/datasette/views/base.py b/datasette/views/base.py
@@ -110,6 +110,9 @@ def database_url(self, database):
     def database_color(self, database):
         return "ff0000"
 
+    async def options(self, request, *args, **kwargs):
+        return Response.text("Method not allowed", status=405)
+
     async def dispatch_request(self, request, *args, **kwargs):
         handler = getattr(self, request.method.lower(), None)
         return await handler(request, *args, **kwargs)

diff --git a/tests/test_html.py b/tests/test_html.py
@@ -52,6 +52,12 @@ def test_http_head(app_client):
     assert response.status == 200
 
 
+def test_homepage_options(app_client):
+    response = app_client.get("/", method="OPTIONS")
+    assert response.status == 405
+    assert response.text == "Method not allowed"
+
+
 def test_favicon(app_client):
     response = app_client.get("/favicon.ico")
     assert response.status == 200