-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI to select name of table at time of upload #17
Comments
I'm going to have a table name field which will be auto-populated when the user selects a file - but that the user can edit themselves. If the filename matches an already-existing table I'll add a |
Here's the current filename code - note that it will over-write an existing table with the same name, which isn't ideal either: datasette-upload-csvs/datasette_upload_csvs/__init__.py Lines 73 to 76 in c613805
|
Right now the upload happens the moment you drop a file onto the drop zone. I'm going to change that so you now have to do that and THEN click upload, in order to give you time to confirm that the filename for the table is what you want. |
Oops, tests fail in Datasette 0.62 but pass in Datasette 0.61. |
Should I bump the minimum required version of Datasette to 0.62? That's only going to be necessary for the tests to pass, not for the plugin to actually work. So I'm going to leave it. |
Picking a better name for the new table is too common a requirement to leave to other plugins such as https://github.com/simonw/datasette-edit-schema
The text was updated successfully, but these errors were encountered: