--setting allow_download 0 causes a 500 error

[simonw]

[ERROR] NameError: name 'false' is not defined
Traceback (most recent call last):
File "/var/lang/lib/python3.9/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
      File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
      File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
      File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
      File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
      File "<frozen importlib._bootstrap_external>", line 850, in exec_module
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "/var/task/vc__handler__python.py", line 12, in <module>
    __vc_spec.loader.exec_module(__vc_module)
      File "<frozen importlib._bootstrap_external>", line 850, in exec_module
      File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
      File "./index.py", line 27, in <module>
    settings={"allow_download": false}
Unknown application error occurred

Originally posted by @simonw in simonw/sfms-history#25 (comment)

[simonw]

Here's the problem:

datasette-publish-vercel/datasette_publish_vercel/__init__.py

Lines 260 to 268 in 57aed0f

	open("index.py", "w").write(
	INDEX_PY.format(
	database_files=json.dumps([os.path.split(f)[-1] for f in files]),
	extras=", {}".format(", ".join(extras)) if extras else "",
	statics=json.dumps(statics),
	settings=json.dumps(dict(settings) or {}),
	crossdb=",\n crossdb=True" if crossdb else "",
	)
	)

Using json.dumps() to produce Python source code means boolean false becomes false and not False.

[simonw]

I'm going to do the cheapest fix: false = False and true = True.

[simonw]

Tested here: https://test-allow-download-0-gau7rnspn-simonw.vercel.app/fixtures