Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: now() got an unexpected keyword argument 'settings' #31

Closed
simonw opened this issue Dec 28, 2020 · 2 comments
Closed

TypeError: now() got an unexpected keyword argument 'settings' #31

simonw opened this issue Dec 28, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Dec 28, 2020

https://github.com/simonw/til/runs/1618711889?check_suite_focus=true

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.6/x64/bin/datasette", line 8, in <module>
    sys.exit(cli())
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/click/core.py", line 829, in __call__
    return self.main(*args, **kwargs)
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/click/core.py", line 782, in main
    rv = self.invoke(ctx)
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/click/core.py", line 1259, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/click/core.py", line 1066, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/hostedtoolcache/Python/3.8.6/x64/lib/python3.8/site-packages/click/core.py", line 610, in invoke
    return callback(*args, **kwargs)
TypeError: now() got an unexpected keyword argument 'settings'
@simonw simonw added the bug Something isn't working label Dec 28, 2020
@simonw
Copy link
Owner Author

simonw commented Dec 28, 2020

Weird, I can't replicate this locally.

@simonw
Copy link
Owner Author

simonw commented Dec 28, 2020

Aha! The problem is in the datasette publish now alias:

@publish.command()
@add_common_publish_arguments_and_options
@add_vercel_options
def now(
files,
metadata,
extra_options,
branch,
template_dir,
plugins_dir,
static,
install,
plugin_secret,
version_note,
secret,
title,
license,
license_url,
source,
source_url,
about,
about_url,
token,
project,
no_prod,
debug,
public,
generate_dir,
):
"Alias for 'datasette publish vercel'"
_publish_vercel(
files,
metadata,
extra_options,
branch,
template_dir,
plugins_dir,
static,
install,
plugin_secret,
version_note,
secret,
title,
license,
license_url,
source,
source_url,
about,
about_url,
token,
project,
no_prod,
debug,
public,
generate_dir,
)

@simonw simonw closed this as completed in 4dfd710 Dec 28, 2020
simonw added a commit that referenced this issue Dec 28, 2020
simonw added a commit to simonw/til that referenced this issue Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant