Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--token feature doesn't work #19

Closed
simonw opened this issue Apr 19, 2020 · 3 comments
Closed

--token feature doesn't work #19

simonw opened this issue Apr 19, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Apr 19, 2020

As seen in e.g. https://github.com/simonw/jsk-fellows-on-twitter/runs/599314532?check_suite_focus=true

Try_double_quotes_·_simonw_jsk-fellows-on-twitter_39a24ba
@simonw simonw added the bug Something isn't working label Apr 19, 2020
@simonw
Copy link
Owner Author

simonw commented Apr 19, 2020

Looks like I forgot to implement it!

@simonw
Copy link
Owner Author

simonw commented Apr 19, 2020

Here's the missing code: https://github.com/simonw/datasette/blob/07e208cc6d9e901b87552c1be2854c220b3f9b6d/datasette/publish/now.py#L106-L112

simonw added a commit that referenced this issue Apr 19, 2020
@simonw
Fix for --token= not working, refs #19
15655d6
simonw added a commit to simonw/jsk-fellows-on-twitter that referenced this issue Apr 19, 2020
@simonw
Use datasette-public-now with fix for --token
0855923 
See simonw/datasette-publish-vercel#19
@simonw
Copy link
Owner Author

simonw commented Apr 19, 2020

That fix works: https://github.com/simonw/jsk-fellows-on-twitter/runs/599367437?check_suite_focus=true

@simonw simonw closed this as completed Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw