Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to add a new column #4

Closed
4 tasks done
simonw opened this issue Mar 15, 2020 · 1 comment
Closed
4 tasks done

Ability to add a new column #4

simonw opened this issue Mar 15, 2020 · 1 comment
Labels
enhancement New feature or request
Milestone
0.3

Comments

@simonw
Copy link
Owner

simonw commented Mar 15, 2020 •
edited
Loading

This one doesn't require a complete rewrite of the table.

  • Add a column
  • Validate column name (cannot already be used)
  • Validate type
  • Show useful error messages
@simonw simonw added the enhancement New feature or request label Mar 15, 2020
simonw added a commit that referenced this issue Mar 15, 2020
@simonw
Initial work on add_column, refs #4
50e1957 
Still needs form validation and nice errors.
@simonw
Copy link
Owner Author

simonw commented Mar 15, 2020 •
edited
Loading

I want to redisplay the edit page with the error message shown there.

Thankfully I don't think I need to ensure the form is re-filled with the previous values, ala Django forms, because it's only a couple of fields.

@simonw simonw added this to the 0.3 (non-alpha) milestone Oct 1, 2020
@simonw simonw closed this as completed in 3d98259 Oct 1, 2020
simonw added a commit that referenced this issue Oct 1, 2020
@simonw
Release 0.3
d08c321 
Refs #4, #19, #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.3
Development

No branches or pull requests
1 participant
@simonw