Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures due to rowid columns #33

Closed
simonw opened this issue Jul 1, 2022 · 2 comments
Closed

Test failures due to rowid columns #33

simonw opened this issue Jul 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@simonw
Copy link
Owner

simonw commented Jul 1, 2022

Tests are failing in CI but not on my laptop: https://github.com/simonw/datasette-edit-schema/runs/7157814881

>       assert table.columns_dict == expected_columns_dict
E       AssertionError: assert {'description...lass 'float'>} == {'description...<class 'int'>}
E         Omitting 2 identical items, use -vv to show
E         Right contains 1 more item:
E         {'rowid': <class 'int'>}
E         Full diff:
E         - {'description': <class 'str'>, 'name': <class 'float'>, 'rowid': <class 'int'>}
E         ?                                                       ------------------------
E         + {'description': <class 'str'>, 'name': <class 'float'>}
@simonw simonw added the bug Something isn't working label Jul 1, 2022
@simonw
Copy link
Owner Author

simonw commented Jul 1, 2022

My laptop has an OLD version of sqlite-utils:

% pip freeze | grep sqlite
sqlite-fts4==1.0.1
sqlite-utils==3.0a0

@simonw
Copy link
Owner Author

simonw commented Jul 1, 2022

It's because of a bug I fixed in sqlite-utils 3.10: https://sqlite-utils.datasette.io/en/stable/changelog.html#v3-10

  • Bug fix: table.transform(), when run against a table without explicit primary keys, would incorrectly create a new version of the table with an explicit primary key column called rowid. (#284)

@simonw simonw closed this as completed in bdf82b1 Jul 1, 2022
simonw added a commit that referenced this issue Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant