Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new datasette.urls.static_plugins() method #22

Closed
simonw opened this issue Oct 24, 2020 · 2 comments
Closed

Use new datasette.urls.static_plugins() method #22

simonw opened this issue Oct 24, 2020 · 2 comments
Labels
blocked enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Oct 24, 2020

Refs simonw/datasette#1033 - this will ensure the plugin works with base_url configuration option.

Relevant code:

datasette-cluster-map/datasette_cluster_map/__init__.py

Line 46 in be66a0b

"/-/static-plugins/datasette_cluster_map/datasette-cluster-map.js",

@simonw simonw added the enhancement New feature or request label Oct 24, 2020
@simonw
Copy link
Owner Author

simonw commented Oct 24, 2020

Blocked awaiting Datasette release containing that method.

@simonw simonw added the blocked label Oct 24, 2020
@simonw
Copy link
Owner Author

simonw commented Jan 23, 2021

This works already! It turns out Datasette handles that here: https://github.com/simonw/datasette/blob/25c2933667680db045851b2cedcf4666d737d352/datasette/app.py#L881-L883

I'll add a test and close this.

@simonw simonw closed this as completed in 4200b95 Jan 23, 2021
simonw added a commit that referenced this issue Jan 23, 2021
@simonw
Release 0.16
0dee93d 
Refs #27, #22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw