Added Sign in with GitHub menu action, closes #65

Refs #62

README.md

@@ -7,7 +7,7 @@
 
 Datasette plugin that authenticates users against GitHub.
 
-The new [0.13a0 alpha release](https://github.com/simonw/datasette-auth-github/releases/tag/0.13a0) requires [Datasette 0.44](https://datasette.readthedocs.io/en/latest/changelog.html#v0-44) or later.
+The new [0.13a0 alpha release](https://github.com/simonw/datasette-auth-github/releases/tag/0.13a0) requires [Datasette 0.51](https://datasette.readthedocs.io/en/latest/changelog.html#v0-51) or later.
 
 ## Setup instructions
 

datasette_auth_github/__init__.py

@@ -8,3 +8,14 @@ def register_routes():
         (r"^/-/github-auth-start$", github_auth_start),
         (r"^/-/auth-callback$", github_auth_callback),
     ]
+
+
+@hookimpl
+def menu_links(datasette, actor):
+    if not actor:
+        return [
+            {
+                "href": datasette.urls.path("/-/github-auth-start"),
+                "label": "Sign in with GitHub",
+            },
+        ]

setup.py

@@ -23,6 +23,7 @@ def get_long_description():
     version=VERSION,
     packages=["datasette_auth_github"],
     entry_points={"datasette": ["auth_github = datasette_auth_github"]},
+    install_requires=["datasette>=0.51"],
     extras_require={
         "test": ["datasette", "pytest", "pytest-asyncio", "httpx", "sqlite-utils"]
     },

test_datasette_auth_github.py

@@ -150,3 +150,14 @@ async def test_github_auth_callback(ds, monkeypatch):
             }
         } == ds.unsign(response.cookies["ds_actor"], "actor")
         assert "/" == response.headers["location"]
+
+
+@pytest.mark.asyncio
+async def test_sign_in_with_github_button(ds):
+    response = await ds.client.get("/")
+    fragment = '<li><a href="/-/github-auth-start">Sign in with GitHub</a></li>'
+    assert fragment in response.text
+    response2 = await ds.client.get(
+        "/", cookies={"ds_actor": ds.sign({"a": {"display": "user"}}, "actor")}
+    )
+    assert fragment not in response2.text