Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

open-csv-from-url should follow redirects #22

Closed
simonw opened this issue Jul 13, 2022 · 3 comments
Closed

open-csv-from-url should follow redirects #22

simonw opened this issue Jul 13, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Owner

simonw commented Jul 13, 2022

Refs:
@simonw simonw added the enhancement New feature or request label Jul 13, 2022
@simonw
Copy link
Owner Author

simonw commented Jul 13, 2022

Relevant test is here:

datasette-app-support/tests/test_open_csv_file.py

Line 66 in 217ba4c

async def test_import_csv_url(httpx_mock, table_name, expected):

@simonw
Copy link
Owner Author

simonw commented Jul 13, 2022

Tested my fix manually by running this in the debug Chrome devtools in the Electron app:

datasetteApp.importCsvFromUrl(
  "https://data.london.gov.uk/download/animal-rescue-incidents-attended-by-lfb/f43b485e-fb35-419c-aa7a-fa75676e5835/Animal%20Rescue%20incidents%20attended%20by%20LFB%20from%20Jan%202009.csv"
)

simonw added a commit that referenced this issue Jul 13, 2022
@simonw
Handle redirects during CSV import, refs #22
d130884
@simonw
Copy link
Owner Author

simonw commented Jul 13, 2022

This is fixed here, but I haven't released it yet. Doesn't feel worthwhile to ship a whole Electron app release for this one change, especially since I'm not currently taking advantage of it (until I reinstate the London Fire Brigade example CSV at least).

@simonw simonw closed this as completed Jul 13, 2022
simonw added a commit that referenced this issue Feb 17, 2023
@simonw
Release 0.11.7
0576818 
Refs #22, #24
simonw added a commit to simonw/datasette-app that referenced this issue Feb 17, 2023
@simonw
Bump to datasette-app-support 0.11.8
b5c1127 
Refs:
- simonw/datasette-app-support#22
- simonw/datasette-app-support#24
- simonw/datasette-app-support#25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simonw