Avoid popping from empty list #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd love to figure out a test that demonstrates this fix. Any idea of steps to reproduce? |
|
This looks harmless enough that I'll merge it without tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the solution proposed by @scott2b in the description of #21:
#21 (comment)
I was getting hit with
NS_ERROR_NET_PARTIAL_TRANSFERwhen trying to implement CSRF protection on my fastapi-users based application and it turns out that applying the fix suggested in the mentioned comment fixed it for me. The server logs were showing that the error was the same as mentioned in #21Submitting this as a PR to see if it can gain enough traction to be merged and eventually warranting a new release of asgi-csrf.
fixes #21