New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vary: Cookie on pages that show csrftoken in form, not pages that set cookies #9

Closed

simonw opened this issue Jun 5, 2020 · 0 comments

Labels

bug

Owner

simonw commented Jun 5, 2020

I made a mistake with #8 - the Vary: Cookie header should protect pages with csrftoken embedded in hidden form field values being cached.

The way I've implemented it has it protect the responses that have a set-cookie header, which is incorrect.

The text was updated successfully, but these errors were encountered:

simonw added the bug label

simonw closed this as completed in

e6058ce

simonw added a commit that referenced this issue


          Release 0.5

a0647ad

Refs #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment