Add option to modify access-control-allow-headers and -methods #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Currently missing tests, will add them as soon as possible. @simonw let me know if there is other things to be finalized/changed here before it can be merged. This would be really helpful to add CORS support for datasettes with plugins like datasette-cors or -graphql and others. |
|
This looks good to me. I'll merge it and add tests. |
simonw
added a commit
that referenced
this pull request
Apr 8, 2024
simonw
added a commit
that referenced
this pull request
Apr 8, 2024
simonw
added a commit
that referenced
this pull request
Apr 8, 2024
simonw
added a commit
that referenced
this pull request
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
headersandmethodsas keywords arguments and adds them to the return headers if set. This is in preparation to add this to https://github.com/simonw/datasette-cors.