Drop support for older versions of Julia and fix some deprecations #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This permits adding a new tag, since METADATA has been frozen for 0.4 and earlier.
ararslan
force-pushed
the
aa/drop-old
branch
from
8e18b54
to
6cffea3
Compare
|
Hm, the 0.7 test failures are more complicated than I had imagined... |
ararslan
force-pushed
the
aa/drop-old
branch
2 times, most recently
from
b3bb80a
to
18262f9
Compare
Repository owner
deleted a comment from
codecov-io
Jan 1, 2018
This requires a test dependency on Compat as well as version conditionals.
Codecov Report
@@ Coverage Diff @@
## master #12 +/- ##
========================================
+ Coverage 92.3% 100% +7.69%
========================================
Files 1 1
Lines 13 9 -4
========================================
- Hits 12 9 -3
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three logically separated commits here. The first drops support for Julia versions prior to 0.5, which will allow registering a new tag in METADATA without requiring an exception. The second works around some deprecations that have happened in 0.7, which necessitates a test dependency on Compat. The last one fixes #13 (which I may have inadvertently caused in #10).
Closes #5