Sat mapmaking refactor #973
Conversation
|
Also, MPI is being removed from the functions in |
…-mapmaking-refactor
sotodlib/mapmaking/obs_grouping.py
Outdated
| @@ -16,7 +16,7 @@ | |||
| """ | |||
|
|
|||
| __all__ = ['build_obslists'] | |||
| import numpy as np | |||
| import numpy as np, sys | |||
There was a problem hiding this comment.
For imports, each module is a separate line.
Looking further below, why is sys.exit used in a support function? Raising an exception would be more Pythonic.
sotodlib/mapmaking/demod_mapmaker.py
Outdated
| """ | ||
| Setup the classes for demod mapmaking and return | ||
| a DemodMapmmaker object | ||
| """ |
There was a problem hiding this comment.
Please format your docstrings a bit more consistently with the rest of sotodlib. The extra indentation is not our practice, should be:
"""
Setup the ...
Same for make_demod_map, below.
sotodlib/mapmaking/demod_mapmaker.py
Outdated
| L : logger, optional | ||
| Logger for printing on the screen. | ||
| site : str, optional | ||
| Plataform name for the pointing matrix. |
sotodlib/mapmaking/demod_mapmaker.py
Outdated
| from .. import coords | ||
| from .. import site_pipeline |
There was a problem hiding this comment.
I don't really like that library code imports things from site_pipeline. That module is sort of special. For now can you import that submodule from inside your driver function?
The load_or_preproc function, or whatever it's called, should probably move to library level... that's beyond the scope of this PR though.
There was a problem hiding this comment.
Ok. I agree, probably this function should be in core next to get_obs. @msilvafe I will create an issue to remind us
First step of the refactoring of the SAT mapmaking code, which is the general function to make a demodulated map (either atomic or depth-1). This will live in
mapmaking.demod_mapmaker.