Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to derive the az el of planets #564

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

tterasaki
Copy link
Contributor

image

To visualize when boresight hits the planet, I want a function to get the trajectory of planet.

@tterasaki tterasaki requested a review from mhasself October 13, 2023 07:56
Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks -- looks useful. However, please eliminate the code duplication. The code in get_source_pos is carefully written, and when you copy-paste that elsewhere you are setting us up for divergence, and different bugs and their fixes ending up in two places instead of one.

Also ... in the future, please do not include bulk reformatting along with content changes.
Bulk reformatting should be avoided unless the situation is really bad. When reformatting is deemed necessary, it should be in a commit by itself, and probably in a PR by itself. That will help people navigate PRs and inspect the commit history in an efficient way.

sotodlib/coords/planets.py Outdated Show resolved Hide resolved
sotodlib/coords/planets.py Show resolved Hide resolved
sotodlib/coords/planets.py Show resolved Hide resolved
…yfield astrometric object which is used both for get_source_pos and get_source_azel
@tterasaki
Copy link
Contributor Author

Thank you for your thoughtful comments. Yeah you are rights.
Now I made a helper function _get_astrometric which is used by both get_source_pos and get_source_azel.

Copy link
Member

@mhasself mhasself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just fix the docstring where noted and then it's ok to merge.

sotodlib/coords/planets.py Show resolved Hide resolved
@tterasaki tterasaki merged commit 9f9b8af into master Oct 16, 2023
4 checks passed
@mhasself mhasself deleted the planet_azel_coords branch March 19, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants