Latest processes for maps #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msilvafe
requested changes
Dec 10, 2024
There was a problem hiding this comment.
Thanks for submitting this! In the future try to turn off your editors autoformatting it adds a lot of extra lines of code to review that are just an extra empty line, space, tab, etc. Also need to match the common sphinx docstring formatting we use and reconcile some redundancies across the code (including with @earosenberg's recent update for subscan flags). I've tried to put sufficient inline comments but let me know if you have questions or if I can help resolve any of these.
chervias
requested changes
Dec 10, 2024
|
I forgot to include this comment in the general message of the review. I agree with @msilvafe, there are a lot of extra tabs in files that will makes go crazy later on if we see them, so please delete them. Thanks! |
…pdated noise logic to incorporate wrap_name from config\n\- added handling for 'fknee' and 'min_noise' in noise process based on user-defined thresholds
chervias
reviewed
Dec 15, 2024
sotodlib/tod_ops/deproject.py
Outdated
| coeffs = np.dot(I, coeffs.T).T | ||
| if correct: | ||
| aman[signal] = aman[signal] - coeffs * med | ||
| return coeffs, med |
msilvafe
approved these changes
Dec 16, 2024
chervias
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #1009
Used with (F+B) script without the "on-the-fly" functions, added to the preprocessing module and to tod_ops and flags: