Toast mlmapmaker updates #1053
Merged
Toast mlmapmaker updates #1053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tskisner
approved these changes
Dec 19, 2024
sotodlib/toast/ops/mlmapmaker.py
Outdated
| maxiter = Int(500, help="Maximum number of CG iterations") | ||
| maxiter = List( | ||
| [500], | ||
| help="Maximum number of CG iterations. Use commas to control each pass separately.", |
There was a problem hiding this comment.
Maybe change the help string to explicitly say, "List of maximum number of CG iterations for each pass".
tests/test_mapmaker_pointing.py
Outdated
| try: | ||
| from . import _helpers as helpers | ||
| except ImportError: | ||
| import _helpers as helpers |
There was a problem hiding this comment.
Why would the relative import fail? We want to make sure we are always importing the _helpers module located in the tests directory, not in other locations.
There was a problem hiding this comment.
With this modification, I can execute this one unit test individually with python tests/test_mapmaker_pointing.py.
There was a problem hiding this comment.
Instead of just doing
python -m unittest tests/test_mapmaker_pointing.py
?
Address review feedback.
Undo recent change. Use 'python -m unittest' instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the TOAST wrapper around the ML mapmaker to support multipass mapmaking and downsampling. Also, add checkpointing capability.
This PR also includes minor tweaks from the MSS3_tweaks branch.