Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAR branch #54

Merged
merged 28 commits into from
Oct 29, 2024
Merged

CAR branch #54

merged 28 commits into from
Oct 29, 2024

Conversation

damonge
Copy link
Collaborator

@damonge damonge commented Oct 28, 2024

All work by @adrien-laposta and @kwolz

car_branch

damonge and others added 25 commits July 17, 2024 13:25
@damonge
calling read/write_map from wrapped function
5a552ea
@damonge
more read/write
313ce76
@damonge
read/write in car too
bfa97ff
@damonge
propagated to existing enmap
8444d5b
@damonge
CAR read/write in metadata_manager
904fce9
@damonge
CAR read/write in metadata_manager
25502d1
@damonge
pix_type through meta
45dee03
@damonge
merged main
5942d0a
@kwolz
SAT beams small change
80bb982
@kwolz
fix unit convention (K for maps, muK for cls)
663c96c
@adrien-laposta
update map utils + mask for CAR
bb97eca
@kwolz
fix plotting bug, enable choosing global hits map
d31a22a
@adrien-laposta
CAR compatibility to get to the TF
a2afb9b
@kwolz
resovlve merger conflict for CAR (2)
5b149f0
@kwolz
added planck tutorial scripts
019c099
@kwolz
resolve merger conflict (3)
9b94add
@kwolz
add sims coadding script
d950891
@kwolz
rebase conflict (4)
6d098b3
@kwolz
flake
084cc5d
@kwolz
update external data preprocesser
f36c79e
@kwolz
jointly plot saccs from sims and data
bf42dbf
@kwolz
clean up paramfiles
9404b14
@kwolz
Added Yued cbundling and sign flip scripts
7b903cf
@kwolz
flaking
9029e31
@kwolz
add run script
2385866
damonge
damonge commented Oct 28, 2024
View reviewed changes
Copy link
Collaborator Author

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments. The main one is about hard-coding the cdelt argument for CAR. It's minor, so happy for you to merge after addressing this.

pipeline/bundling/bundle_atomic_maps.py Show resolved Hide resolved
pipeline/transfer/compute_pseudo_cells_tf_estimation.py Outdated Show resolved Hide resolved
pipeline/get_mode_coupling.py Outdated Show resolved Hide resolved
@adrien-laposta
Copy link
Collaborator

Most of the pipeline is now compatible with CAR pixelization. Some more work is necessary to clean/unittest CAR handling functions and adapt remaining scripts. In the current state, one can run the pipeline to transfer function/power spectrum estimation in both CAR and Healpix.

@adrien-laposta adrien-laposta merged commit a59e032 into main Oct 29, 2024
1 check failed
@adrien-laposta adrien-laposta deleted the CAR branch October 29, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien-laposta adrien-laposta adrien-laposta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@damonge @adrien-laposta @kwolz