Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting mask handling #30

Merged
merged 13 commits into from
Jan 15, 2024
Merged

Correcting mask handling #30

merged 13 commits into from
Jan 15, 2024

Conversation

kwolz
Copy link
Collaborator

@kwolz kwolz commented Jan 11, 2024

This PR fixes a longstanding bug affecting the transfer function, caused by the analysis mask being insufficiently apodized.
It also solves an issue related to the ell-range of the mode coupling matrix: NmtBin now contains the multipole range [0, 3*nside] instead of being cut to the analysis range.
The analysis mask is now either downloaded explicitly (this requires the user to check that the nhits map is compatible), or auto-assembled from the hits map (option --self_assemble of mask_handler.py).

@kwolz kwolz requested a review from adrien-laposta January 11, 2024 22:21
@adrien-laposta adrien-laposta merged commit 375f4e3 into main Jan 15, 2024
1 check passed
@kwolz kwolz deleted the mask_handling branch February 11, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants