Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps #56

Merged
merged 1 commit into from
Jul 24, 2021
Merged

Bump deps #56

merged 1 commit into from
Jul 24, 2021

Conversation

AlecRust
Copy link
Collaborator

@AlecRust AlecRust commented Jul 19, 2021 •
edited
Loading

Current Problem

Dependencies in this are getting out of date resulting in warnings e.g.

(node:7239) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/alec/projects/project-name/node_modules/stylelint-selector-bem-pattern/node_modules/postcss/package.json.
Update this package.json to use a subpath pattern like "./*".

Specifically this warning is coming from PostCSS dependency.

Solution

Upgrade all dependencies. Includes:

  • package-lock.json converted to new format
  • Deprecated space-after-keywords ESLint rule replaced with keyword-spacing
  • yarn test and yarn lint passing

This closes all other open PRs.

@AlecRust AlecRust merged commit f43129f into simonsmith:master Jul 24, 2021
@AlecRust AlecRust deleted the upgrades branch July 24, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsmith simonsmith simonsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlecRust @simonsmith