Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented branch coverage tool for AuthorListParser::getToken #7

Merged
merged 5 commits into from
Feb 18, 2020
Merged

Implemented branch coverage tool for AuthorListParser::getToken #7

merged 5 commits into from
Feb 18, 2020

Conversation

yiiju
Copy link
Collaborator

@yiiju yiiju commented Feb 16, 2020

Added

  • Branch coverage tool for AuthorListParser::getToken.

@yiiju yiiju changed the title Get token Implemented branch coverage tool for AuthorListParser::getToken Feb 16, 2020
@SoFoDa SoFoDa self-requested a review February 17, 2020 15:28
SoFoDa
SoFoDa approved these changes Feb 17, 2020
View reviewed changes
Copy link
Collaborator

@SoFoDa SoFoDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

christinerosquist
christinerosquist approved these changes Feb 18, 2020
View reviewed changes
Copy link
Collaborator

@christinerosquist christinerosquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🔥

simonsirak
simonsirak reviewed Feb 18, 2020
View reviewed changes
Copy link
Owner

@simonsirak simonsirak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nice job! I had a similar comment as David but otherwise it looks great!

src/main/java/org/jabref/model/entry/AuthorListParser.java Show resolved Hide resolved
@yiiju yiiju merged commit 8a14a90 into master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsirak simonsirak simonsirak left review comments

@christinerosquist christinerosquist christinerosquist approved these changes

@SoFoDa SoFoDa SoFoDa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yiiju @simonsirak @SoFoDa @christinerosquist