Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop rollup-plugin-ts, use updated addon blueprint #655

Merged
merged 9 commits into from
Jul 20, 2023

Conversation

simonihmig
Copy link
Owner

Update the addon boilerplate to align with embroider-build/addon-blueprint#136.

@@ -99,15 +105,15 @@
"exports": {
".": "./dist/index.js",
"./*": {
"types": "./dist/*.d.ts",
"types": "./declarations/*.d.js",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if the *.d.js is a typo.

In my addons, I wrote the following for "." and "./*":

"exports": {
  ".": {
    "types": "./declarations/index.d.ts",
    "default": "./dist/index.js"
  },
  "./*": {
    "types": "./declarations/*.d.ts",
    "default": "./dist/*.js"
  },
  "./addon-main.js": "./addon-main.cjs"
},

@simonihmig simonihmig merged commit e0e7057 into master Jul 20, 2023
@simonihmig simonihmig deleted the update-rollup-ts branch July 20, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants