Ensure PortalTarget onChange is called on initial render

[meirish]

Fixes #527.

[meirish]

I looked into this a bit, but wasn't sure how you'd prefer to fix it.

The issue seems to be that because of the next wrapping here https://github.com/kaliber5/ember-stargate/blob/2f55bd96bccea7e3414c33b2ec92526cb2738a70/packages/ember-stargate/src/services/-portal.ts#L48 when registering the PortalTarget, that means that target here: https://github.com/kaliber5/ember-stargate/blob/2f55bd96bccea7e3414c33b2ec92526cb2738a70/packages/ember-stargate/src/services/-portal.ts#L65 is undefined so the onChange doesn't get called.

It looks like wrapping the body of registerPortal here in a next like registerTarget does fixes this, but I'm uncertain if that has any knock-on effects.

[simonihmig]

Thanks for the test! There are some linting errors, could you please fix them? (you can run yarn lint locally)

Your observations regarding next() make a lot of sense. I don't really recall why I used that in the first place. Will look into it...

[simonihmig]

Ok, so without that next() call, this test is failing, with Portal target with name main already exists. Which makes sense, as when creating a new target with the same name, it would be in conflict with the "soon to be destroyed but not quite yet" target, when the order of calls is 1. register new target, 2. unregister old target. So we have to make sure that unregister happens first, which is what the next() call on register (not unregister!) does.

So it would be consistent to also wrap registerPortal in next(), to ensure it happens always after any unregisterPortal calls, when both are called in the same event loop. Which is what you suggested.

So @meirish, if you have the time to turn this "failing test" PR into a full bug fixing PR, by adding a commit that does what we discussed above, then please do so, would be highly appreciated! 😀

but I'm uncertain if that has any knock-on effects.

I don't think so. If all other tests still pass, which is what I would assume, then I am confident this is ok!

[simonihmig]

All tests pass! 🎉

Thank you!

[simonihmig]

https://github.com/kaliber5/ember-stargate/releases/tag/v0.4.3

[meirish]

Awesome, thank you!