Dependency conflicts since nx version 16.8.1

[simondotm]

          Hey Simon I am working with nx version `16.8.1`  and I had a problem that I fixed in the end.

Steps to reproduce

• nx version 16.8.1
• Install "@simondotm/nx-firebase": "^2.1.0"
• Create a functions firebase app with your extension
• package.json got modified with "esbuild": "^0.17.17"

Current behaviour
You can't run npm install any longer for a conflict between esbuild and "@nx/esbuild": "16.8.1",

My fix
In my case I have to change the version of "esbuild": "^0.17.17" to "esbuild": "^0.19.2"

If I removed esbuild = no more compilations of the functions

I hope it could help the next one.

Than you for your work @simondotm !!

Originally posted by @pikilon in #151 (comment)

[simondotm]

Not gonna lie - this one is a headache. Not sure why this happens or how to fix it. 😕

[pikilon]

While it's works (and does) it is ok El sáb, 14 oct 2023, 15:07, Simon M ***@***.***> escribió:

…

Not gonna lie - this one is a headache. Not sure why this happens or how to fix it. 😕 — Reply to this email directly, view it on GitHub <#155 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXEYZIJZWQOV7LEEFTVKDLX7KE7RAVCNFSM6AAAAAA5LSL762VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONRSHA4DSNJUHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[mjbates7]

@simondotm fyi I had this issue I raised with the nx team on their discord (and someone else did on their GH) and it looks like they've now fixed it: nrwl/nx#19728

[simondotm]

@mjbates7 ok thats good news, thanks for sharing this.
I guess this means we will all have to update Nx again in our workspaces, and that Nx versions 16.8.1 thru to whichever nx release that fix arrives will be incompatible for us nx-firebase plugin users. 😕

[mjbates7]

Seems like it. It's landed in their latest v17.0.0 release https://github.com/nrwl/nx/releases/tag/17.0.0 as a heads up so I'll probably migrate to that now

[pikilon]

I have migrated my personal project ([email protected]) to [email protected] and everything is fine and fixed, this is what I did:

• nx run migrations latest and --run-migrations
• removed [email protected] dependency using yarn
• deleted dist, node_modules and yarn.lock
• npx nx deploy firebase (including complex cloud-functions app)

Everything deployed correctly

Changes introduced by nx migration on nx-firebase projects

In the function app cloud-functions I have this change in the project.json (this change is done in all the projects in the workspace)
From

    "lint": {
      "executor": "@nx/linter:eslint",

To

    "lint": {
      "executor": "@nx/eslint:lint",

I hope this could help in the development, thank you @simondotm keep up the good work

[simondotm]

Great news, thanks for the update. Seems like Nx 17 is the way to go then.

@pikilon thanks for the migration note too. I think we're ok in the plugin because it uses the @nx/node plugin to scaffold function apps, which will use whichever Nx version is in the workspace.

So if already on Nx 17, it should scaffold the app with @nx/eslint
With pre-Nx-17, it will scaffold with @nx/linter but the Nx migration tool will take care of ensuring nx-firebase function apps stay upto date.

I'm glad I made this change to decouple node app generators in the v2 plugin; the original v1 plugin had its own implementation which would have been a real pain to keep the schemas upto date with the dizzying Nx release cadence. 😅

[pikilon]

Sorry to bring bad news, Maybe is only related to my project
#163

[simondotm]

Closing this issue as resolved.
Plugin users for Nx versions prior to 16.8.1 should update Nx to 17.0.0 or higher.