Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit and linters configuration #79

Merged
merged 1 commit into from
May 6, 2024

Conversation

azmeuk
Copy link
Contributor

@azmeuk azmeuk commented May 6, 2024

This PR adds a pre-commit configuration, with ruff, and applies it.
It also adds tox and GHA configuration to check the style is correct.
It removes remaining python 2 pieces of code, and comments.

Comment on lines +13 to +14
assert time
assert datetime
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what are these asserts for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little hack so the linter won't remove the imports, as it believes the module are not called in the file.
Actually there is a eval that does call them dynamically, so the asserts make the linter happy.

@simon-weber simon-weber merged commit 32f39aa into simon-weber:master May 6, 2024
41 checks passed
@simon-weber
Copy link
Owner

thanks!

@azmeuk azmeuk deleted the pre-commit branch May 6, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants