Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a generic trigger mechanism #41

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

maiamiguel
Copy link

@maiamiguel maiamiguel commented Sep 25, 2023

Description

In this PR I have address the following:

  • Created a demo app that includes the SPM package to showcase its behaviour
  • Added app assets to the demo app
  • Changed documentation accordingly
  • Changed the trigger mechanism to consider other types and not only Integers as before

Related Issues

Issue #36

Checklist

  • Have you added tests where necessary? Do all the test pass?
  • Have you added descriptive comments to your code?
  • Have you updated the documentation related to this proposal

@simibac let me know what you think 🙏

@maiamiguel maiamiguel marked this pull request as ready for review September 26, 2023 09:05
@maiamiguel maiamiguel changed the title Creating a generic trigger mechanism not strong typed Creating a generic trigger mechanism Sep 26, 2023
@MojtabaHs
Copy link

Thanks for your contribution. This PR contains too many changes. Maybe breaking it into smaller chunks can help the owner to merge it easier.

Suggestion:

  • A PR for making the trigger generic (including rename the property and updates for the docs accordingly)
  • A PR for adding a demonstration of these changes (including the app and the needed assets)

@OmarJalil
Copy link

You should create the Example app inside a folder named Example, the way you added an additional folder level will cause SPM to not find the package in the project, but the change is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants