apply arm64 windows workaround only on older version msvc #1121
Conversation
Changqing-JING
force-pushed
the
remove_arm64_windows_work_around
branch
from
f8a78e1
to
a65d98d
Compare
simde/arm/neon/sqadd.h
Outdated
| #define vsqaddd_u64(src1, src2) neon_usqadds64(__uint64ToN64_v(src1), __int64ToN64_v(src2)).n64_u64[0] | ||
| #if (defined _MSC_VER) && (_MSC_VER < 1938) | ||
| #pragma message ("_MSC_VER value is: " _CRT_STRINGIZE(_MSC_VER)) | ||
| #error "due to the bug of MSVC, this current version of visual studio is not supported. Please update. See https://developercommunity.visualstudio.com/t/In-arm64_neonh-vsqaddb_u8-vsqaddh_u16/10271747?sort=newest" |
There was a problem hiding this comment.
Thanks for this PR. Can we keep the workaround for old versions of MSVC and issue a warning?
There was a problem hiding this comment.
Sure, changed as your idea
Changqing-JING
force-pushed
the
remove_arm64_windows_work_around
branch
from
a65d98d
to
cbcbb50
Compare
Changqing-JING
changed the title
|
@mr-c why can emscripten test fail on this PR? This PR should not be related to emscripten |
The emscripten tests use the latest "tip-of-tree" build of emcc/clang to catch issues early. So it wasn't your change, but their change. Next we need to see if the stable emsdk version also fails, and if not, to switch to that from the "tot" version. Simultaneously we should file an issue with the emscripten people |
|
This might be the cause, so hopefully we can try again when the fix is released |
The arm_neo.h bug of msvc is fixed. So that the workaround is not needed on new msvc