Tests: Fixed test execution #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t20100
commented
Jan 12, 2024
| PROJECT_DIR = os.path.dirname(os.path.abspath(__file__)) | ||
| PROJECT_NAME = get_project_name(PROJECT_DIR) | ||
| logger.info("Project name: %s", PROJECT_NAME) | ||
|
|
||
| project_module = import_project_module(PROJECT_NAME, PROJECT_DIR) | ||
| PROJECT_VERSION = getattr(project_module, "version", "") | ||
| PROJECT_PATH = project_module.__path__[0] | ||
| PROJECT_PATH = str(Path(project_module.__path__[0]).resolve()) |
There was a problem hiding this comment.
Use resolve to use canonical path
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR runs
pytestin a subprocess for bothsilx.test.run_testsandrun_tests.py.Previous way of running tests had issue with pytest 8.0.0rc1 apparently because of the module path. Since
pytestis playing with the imports, it is anyway best IMO to run it separately.Failing CI: