Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataclass for worker config #2363

Merged
merged 34 commits into from
Jan 10, 2025
Merged

Conversation

kif
Copy link
Member

@kif kif commented Dec 19, 2024

First define the dataclass ... then use it. Probably in several other PR
related to #2360

@kif kif requested a review from t20100 December 19, 2024 17:05
@kif kif added quality Pay-off some technical dept proposal Something which have to be tested labels Dec 19, 2024
@kif
Copy link
Member Author

kif commented Dec 19, 2024

@t20100 This is a first attempt to design such an object. The PR is far from being complete but I would like your point of view on this...

@kif kif self-assigned this Dec 26, 2024
@kif
Copy link
Member Author

kif commented Dec 26, 2024

Remains to be upgraded, mostly the worker class.

Copy link
Member

@t20100 t20100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds a good step forward for me for unifying the config management!

src/pyFAI/worker.py Outdated Show resolved Hide resolved
src/pyFAI/io/integration_config.py Outdated Show resolved Hide resolved
src/pyFAI/io/integration_config.py Outdated Show resolved Hide resolved
src/pyFAI/io/integration_config.py Outdated Show resolved Hide resolved
src/pyFAI/io/integration_config.py Show resolved Hide resolved
src/pyFAI/io/integration_config.py Show resolved Hide resolved
src/pyFAI/io/integration_config.py Show resolved Hide resolved
src/pyFAI/io/integration_config.py Outdated Show resolved Hide resolved
src/pyFAI/io/integration_config.py Show resolved Hide resolved
src/pyFAI/io/integration_config.py Outdated Show resolved Hide resolved
@kif kif added ready to merge Please review and removed proposal Something which have to be tested labels Jan 7, 2025
@kif kif merged commit de441d5 into silx-kit:main Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality Pay-off some technical dept ready to merge Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants