-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dataclass for worker config #2363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kif
added
quality
Pay-off some technical dept
proposal
Something which have to be tested
labels
Dec 19, 2024
@t20100 This is a first attempt to design such an object. The PR is far from being complete but I would like your point of view on this... |
Remains to be upgraded, mostly the worker class. |
t20100
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds a good step forward for me for unifying the config management!
Co-authored-by: Thomas VINCENT <[email protected]>
Co-authored-by: Thomas VINCENT <[email protected]>
Co-authored-by: Thomas VINCENT <[email protected]>
Co-authored-by: Thomas VINCENT <[email protected]>
define the default value for an accumulator
kif
added
ready to merge
Please review
and removed
proposal
Something which have to be tested
labels
Jan 7, 2025
Co-authored-by: Thomas VINCENT <[email protected]>
…' into 2360_dataclass_for_worker_config
Typing is not my business
…' into 2360_dataclass_for_worker_config
…' into 2360_dataclass_for_worker_config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First define the dataclass ... then use it. Probably in several other PR
related to #2360