-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transform null
in NaN
in h5grove and Jupyter providers
#776
Conversation
Nice and simple implementation, but three concerns (which I'm sure you're aware of):
The second concern is particularly critical to me, since we could potentially "lie" to the user by showing them |
True. I completely missed
Yes but again, this is not something we can solve on the front-end for now. I thought that displaying
I wholeheartedly agree. A quick search shows that
Well, I think
I made some tests that we need to discuss but binary support might not come that fast 😹 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, let's do this then.
af4c253
to
556fada
Compare
Closing for now as the fix may not be worth the performance impact of the |
Fixes Jupyter/h5grove issues reported in #641 (comment):